Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add library tests for market balance, pool interactions #75

Merged
merged 18 commits into from
Jan 5, 2023
Merged

test: add library tests for market balance, pool interactions #75

merged 18 commits into from
Jan 5, 2023

Conversation

pakim249CAL
Copy link
Contributor

Pull Request

Issue(s) fixed

This pull request fixes #72, #73

This was linked to issues Jan 2, 2023
Market Balance Lib tests #72
Closed
Pool Interactions Lib Test #73
Closed
Base automatically changed from feat/test-framework-json to main January 3, 2023 14:49
@pakim249CAL pakim249CAL marked this pull request as ready for review January 3, 2023 14:49
MerlinEgalite
MerlinEgalite requested changes Jan 3, 2023
View reviewed changes
src/MorphoGetters.sol Outdated Show resolved Hide resolved
test/libraries/TestMarketLib.sol Show resolved Hide resolved
test/helpers/User.sol Show resolved Hide resolved
test/helpers/User.sol Outdated Show resolved Hide resolved
test/setup/TestSetup.sol Show resolved Hide resolved
test/libraries/TestMarketBalanceLib.sol Show resolved Hide resolved
test/libraries/TestMarketBalanceLib.sol Outdated Show resolved Hide resolved
test/libraries/TestPoolInteractions.sol Outdated Show resolved Hide resolved
test/libraries/TestPoolInteractions.sol Outdated Show resolved Hide resolved
Rubilmax
Rubilmax reviewed Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a comment

MerlinEgalite
MerlinEgalite requested changes Jan 4, 2023
View reviewed changes
src/MorphoInternal.sol Outdated Show resolved Hide resolved
test/libraries/TestPoolInteractions.sol Outdated Show resolved Hide resolved
Rubilmax
Rubilmax approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

Approving since the PR is fat enough as is, but I do think what I suggest is worth opening an issue in case we don't want to apply it now

test/TestMorphoInternal.sol Outdated Show resolved Hide resolved
test/helpers/User.sol Outdated Show resolved Hide resolved
test/TestMorphoInternal.sol Outdated Show resolved Hide resolved
test/libraries/TestMarketBalanceLib.sol Outdated Show resolved Hide resolved
test/libraries/TestPoolInteractions.sol Outdated Show resolved Hide resolved
test/libraries/TestPoolInteractions.sol Outdated Show resolved Hide resolved
Rubilmax
Rubilmax approved these changes Jan 5, 2023
View reviewed changes
test/libraries/TestMarketLib.sol Show resolved Hide resolved
@Rubilmax Rubilmax mentioned this pull request Jan 5, 2023
Merged
@pakim249CAL
Copy link
Contributor Author

Removing the morpho internal tests for now, as this should not block this PR.

Rubilmax
Rubilmax approved these changes Jan 5, 2023
View reviewed changes
src/MorphoStorage.sol Show resolved Hide resolved
@pakim249CAL pakim249CAL merged commit 30ef7e8 into main Jan 5, 2023
@pakim249CAL pakim249CAL deleted the test/libraries branch January 5, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pool Interactions Lib Test Market Balance Lib tests
3 participants
@pakim249CAL @Rubilmax @MerlinEgalite