refactor: internalize market creation and increase deltas #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 11, 2023
pakim249CAL
changed the title
Rubilmax
previously approved these changes
Jan 12, 2023
Yes. It would be immensely helpful and more secure to have an internal market creation function to exist rather than having duplicates in tests imo. |
MerlinEgalite
previously approved these changes
Jan 12, 2023
pakim249CAL
dismissed stale reviews from MerlinEgalite and Rubilmax
via
7546508
|
I still have an unresolved comment. Do you want to address it in a future PR? |
MerlinEgalite
approved these changes
Jan 13, 2023
Rubilmax
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue(s) fixed
This pull request fixes: