Separate fork tests from integration tests #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
force-pushed
the
test/fork-tests
branch
from
616c4d8
to
3a21193
Compare
Base automatically changed from
test/matching-engine
to
test/morpho-internal-1
January 11, 2023 16:59
pakim249CAL
previously approved these changes
Jan 11, 2023
MerlinEgalite
approved these changes
Jan 12, 2023
Closed
pakim249CAL
approved these changes
Jan 12, 2023
This was referenced Jan 13, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue(s) fixed
This pull request fixes #57
The CI is failing on purpose: I am introducing a failing test which showcases that we have an unexpected behavior in our contracts
I won't fix the contracts in this PR, for the sake of readability
So we should either merge this on
main(which am ok with because we're in development, a failing CI onmainis not such a big deal), or wait for another PR on top to be merged then merge this onmainIn the second case, please build your tests on top as this PR introduces a lot of conventions 🙏
EDIT: the test passes on #135