Fork at test construction #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
force-pushed
the
test/integration-tests
branch
from
0b11e35
to
0dcf0b7
Compare
Rubilmax
force-pushed
the
test/integration-tests
branch
from
0dcf0b7
to
6894af4
Compare
MerlinEgalite
approved these changes
Jan 5, 2023
|
This is really good. Seems quite generalizable to any foundry repo. To the point that I think the config lib can actually be part of morpho-utils. |
pakim249CAL
approved these changes
Jan 5, 2023
I think it is generalizable, but I am still not satisfied with the setup because you need to read the json config twice for each internal test... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue(s) fixed
This is the cleanest I could get to have integrated internal tests
This PR also contains a proposal for managing the test config