-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emergency section in the README #380
Conversation
Co-authored-by: Quentin Garchery <QGarchery@users.noreply.github.com> Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Two other scenario we could document:
- the guardian suspects bad behavior from the curator/owner -> revoke everything continuously, explain the situation, and can advocate for removing funds if no solution can be found
- the allocators can pause the deposits (for example in case of a suspected contract bug involving depositing funds) by setting the supplyQueue to the empty list
Do you thing we should add them @morpho-org/onchain-reviewers ?
Indeed I think it's worth it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This README is what vault owners will read during an emergency, so, so it should directly link to default bundles for emergency situations, or link to a specific doc page that has those bundles.
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
I don't get your suggestion: we can't prepare bundles because they are specific to MM addresses and configuration? |
(I had default Safe bundle skeletons in mind) After discussion with Romain the best would be foundry script with options. That's enough for EOA allocators, and the resulting tx will also be convertible into Safe bundles. @MerlinEgalite @Rubilmax |
moved the discussion to #383! |
Co-authored-by: Quentin Garchery <QGarchery@users.noreply.github.com> Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
ah formatting is broken it seems @Jean-Grimal |
Fixes #375
Should I add subsections about rogue guardian and owner takeover ?
I haven't done it yet because it require to deploy a new vault and to migrate positions to this new vault, and I was not sure such operations should be explained/described in this file.