-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove automatic supply queue push #351
Remove automatic supply queue push #351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this discussion needs to be resolved first: https://github.com/morpho-org/metamorpho/pull/351/files#r1427738018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also fixes MM-3 from my report (but duplicates can still be set manually, and so maxDeposit
can still be wrong).
if (newCap > 0) { | ||
if (!isEnabled) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (newCap > 0) { | |
if (!isEnabled) { | |
if (newCap > 0 && !isEnabled) { |
The PR seems OK. Consider documenting the de-sync between the You could have the whole |
Yes this is a wanted behavior: some vault curators will prefer reallocating every time instead of using the supply queue.
I think it's ok considering that there is already other functions that could desync the two queues (which seems natural since the code has 2 queues, so it would make sense if they are not always the same) |
https://morpholabs.slack.com/archives/C02N7CSP91C/p1702569747842329
and fixes #352