Morphik UI for Docker #93
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error: Agent timed out after 12 minutes of thinking |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| volumes: | ||
| - ./ui-component:/app/ui-component | ||
| working_dir: /app/ui-component | ||
| command: bash -c '. /root/.nvm/nvm.sh && nvm use --lts && npm install && npm run dev' |
There was a problem hiding this comment.
Running 'npm install' at container startup can introduce inconsistency if package versions change between deployments
| - ./ui-component:/app/ui-component | ||
| working_dir: /app/ui-component | ||
| command: bash -c '. /root/.nvm/nvm.sh && nvm use --lts && npm install && npm run dev' | ||
| depends_on: |
There was a problem hiding this comment.
Missing health check condition for the morphik dependency
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Install NVM and Node.js LTS, make Node & npm available at runtime | ||
| RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.2/install.sh | bash && \ |
There was a problem hiding this comment.
Piping remote scripts directly to bash without verification is a security risk
| @@ -0,0 +1,28 @@ | |||
| FROM ubuntu:22.04 | |||
There was a problem hiding this comment.
Dockerfile runs as root user which is a security risk
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.