Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added table highlight on hover #2730

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

shaji618
Copy link

@shaji618 shaji618 commented Oct 19, 2024

Just a little change that I have on my instance of Bazarr that I thought would be a nice quality-of-life improvement. Happy to make changes if we don't want this happening on every table like I have it now (or discard this change altogether if the maintainers don't like it).

@anderson-oki anderson-oki changed the title add highlightOnHover prop to BaseTable component Added table highlight on hover Oct 20, 2024
@shaji618
Copy link
Author

shaji618 commented Oct 20, 2024

Hey @anderson-oki, while looking at issues with configuration on a friend's instance of Bazarr, we noticed that the strings here and here are slightly confusing. What do you think about changing them to something like "Set a default profile for {Series/Movie}. Note that this is not retroactive and will only apply to Series added after this option is enabled." (I recognize that it's verbose, but something like that?)? Again, totally willing to just leave it alone but can make this change within this PR if y'all are receptive.

@morpheus65535 morpheus65535 merged commit f58c863 into morpheus65535:development Oct 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants