Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert back ncccgeth for compaitable #151

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

MarvelFisher
Copy link
Collaborator

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@MarvelFisher MarvelFisher requested a review from a team as a code owner October 16, 2024 07:50
@MarvelFisher MarvelFisher merged commit c5df426 into main Oct 16, 2024
@MarvelFisher MarvelFisher deleted the feature/mainnet-mk branch October 16, 2024 07:55
github-actions bot pushed a commit that referenced this pull request Oct 16, 2024
Co-authored-by: marvel.yu <marvel.yu@bitget.com>
FletcherMan pushed a commit that referenced this pull request Oct 16, 2024
revert back ncccgeth for compaitable (#151)

Co-authored-by: marvel.yu <marvelfisher@gmail.com>
Co-authored-by: marvel.yu <marvel.yu@bitget.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants