Fix unwanted input focus after mouse up event on document #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, this PR fixes the bug. For now, I'll use 9.4.0 until this merged. |
|
Thanks @aberezkin for fixing this! Published as v9.4.2 now. |
|
THANK YOU @aberezkin! Was racking my brain since yesterday trying to figure this one out. |
ghost
mentioned this pull request
|
@moroshko any chance you could publish this new version to npm? |
stephyeung
pushed a commit
to range-labs/react-autosuggest
that referenced
this pull request
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autosuggest didn't set
this.pressedSuggestionto null ifthis.justSelectedSuggestionistrue. That's is the case when we are just clicking a suggestion in the dropdown.I wrote a test to prevent this regression again. My first intention was to put it in
plain-listtests section but it seems thatblurInput()helper doesn't take effect iffocusInputOnSuggestionClickistrue(isInputFocusedreturnstrue) and test failed even with new changes. So I put it underdo-not-focus-input-on-suggestion-clicksection where it fails without change and passes with it.Fixes #568