Make MCP resources canonical and retire toolsets - #220
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #194.
Resolves #195.
Resolves #196.
Resolves #197.
Summary
GitContribute now exposes one stable MCP catalog and relies on host-native discovery instead of setup-time toolset selection. Durable dossiers, investigations, opportunities, evidence, and readiness reports use MCP resources as their canonical detailed representation; producer tools return compact typed references and native resource links.
The change removes the legacy
--toolsetspath, the retired[output]config shim, the top-levelsyncguidance shim, and overlapping scalar artifact getters. It also replaces historical v1-v4 evaluation fixtures with the current v5 unified-catalog condition while retaining deterministic in-memory MCP contract tests.Compatibility
This deliberately removes compatibility surfaces instead of preserving another migration layer:
resources/read; Codex exposes it asread_mcp_resource.--read-only.[output]section now fail strict decoding and must remove that section.--toolsetsis no longer accepted. Host-native tool search or lazy loading owns catalog context management.Validation
make verify— passed: uncached short tests, golangci-lint, module tidiness, generated-output verification, and documentation validation.Review order
internal/mcpserver/resource_links.go,v1.go, andserver.gofor the canonical resource boundary.internal/mcpserver/catalog.go,internal/mcpadapter/runner.go, and CLI/config changes for unified discovery and compatibility removal.internal/mcpserver/server_contract_test.gofor resource-link and catalog assertions.internal/mcpserver/testdata/agent-eval/v5andagent_eval_test.gofor evaluation cleanup.