Skip to content

Make MCP resources canonical and retire toolsets - #220

Merged
morluto merged 2 commits into
mainfrom
codex/canonical-mcp-resources
Jul 29, 2026
Merged

Make MCP resources canonical and retire toolsets#220
morluto merged 2 commits into
mainfrom
codex/canonical-mcp-resources

Conversation

@morluto

@morluto morluto commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Resolves #194.
Resolves #195.
Resolves #196.
Resolves #197.

Summary

GitContribute now exposes one stable MCP catalog and relies on host-native discovery instead of setup-time toolset selection. Durable dossiers, investigations, opportunities, evidence, and readiness reports use MCP resources as their canonical detailed representation; producer tools return compact typed references and native resource links.

The change removes the legacy --toolsets path, the retired [output] config shim, the top-level sync guidance shim, and overlapping scalar artifact getters. It also replaces historical v1-v4 evaluation fixtures with the current v5 unified-catalog condition while retaining deterministic in-memory MCP contract tests.

Compatibility

This deliberately removes compatibility surfaces instead of preserving another migration layer:

  • MCP clients must support protocol-level resources/read; Codex exposes it as read_mcp_resource.
  • The complete catalog is visible by default, including annotated local-write and process-execution tools. Deployments that require a read-only capability boundary should continue using --read-only.
  • Existing config files containing the retired [output] section now fail strict decoding and must remove that section.
  • --toolsets is no longer accepted. Host-native tool search or lazy loading owns catalog context management.

Validation

  • make verify — passed: uncached short tests, golangci-lint, module tidiness, generated-output verification, and documentation validation.
  • Codex resource-follow evaluation — 3/3 runs followed compact durable references through the exact MCP resource URI.

Review order

  1. internal/mcpserver/resource_links.go, v1.go, and server.go for the canonical resource boundary.
  2. internal/mcpserver/catalog.go, internal/mcpadapter/runner.go, and CLI/config changes for unified discovery and compatibility removal.
  3. internal/mcpserver/server_contract_test.go for resource-link and catalog assertions.
  4. internal/mcpserver/testdata/agent-eval/v5 and agent_eval_test.go for evaluation cleanup.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@cursor

cursor Bot commented Jul 29, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@morluto
morluto merged commit bf443f1 into main Jul 29, 2026
14 checks passed
@morluto
morluto deleted the codex/canonical-mcp-resources branch July 29, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant