Skip to content

Commit

Permalink
attempting to fix the CRAN issue with adding skip_on_cran()
Browse files Browse the repository at this point in the history
  • Loading branch information
moritzpschwarz committed Oct 19, 2023
1 parent 96cdc54 commit da78531
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 7 deletions.
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

## Bug fixes

- Bugfix in robust_isatpanel(). Before it appeared like HAC S.E. with clusters were possible. This has been fixed. Now also the estimation type is taken from the inital model rather than specified as a separate argument; hence 'effect' has been removed as an argument.
- Bugfix in robust_isatpanel(). Before it appeared like HAC S.E. with clusters were possible. This has been fixed. Now also the estimation type is taken from the initial model rather than specified as a separate argument; hence 'effect' has been removed as an argument.
- Bugfixes in plotting to work with uis specifications
- Improved plotting when there is just a single identified break (now the colour scale adjusts)

Expand Down
11 changes: 10 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
## Resubmission

Changes in version 0.1.5: This is a minor update to fix a few small bugs and enable some further analysis tools.
### This is a resubmission:
The pre-tests failed with the error (only on DEBIAN and only on CRAN, not on win-builder or rhub):
"Running R code in ‘testthat.R’ had CPU time 3 times elapsed time"
I therefore made changes to the testing files and included skip_on_cran() a few times.



### General changes in version 0.1.5:

This is a minor update to fix a few small bugs and enable some further analysis tools.

- Fixed a bug and added automated testing for `robust_isatpanel()`
- I fixed a further small error in robust_isatpanel() that produced incorrect results when "time" was not a factor
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-1-isatpanel-short.R
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ test_that("Test the cfesis and csis arguments",{


test_that("Standard Error Options using fixest",{

skip_on_cran()
expect_silent(result <- isatpanel(data = pandata_simulated,formula = gdp~temp + I(temp^2), index = c("country","year"),fesis=TRUE, ar = 1, print.searchinfo=FALSE,engine = "fixest"))
expect_silent(result <- isatpanel(data = pandata_simulated,formula = gdp~temp + I(temp^2), index = c("country","year"),fesis=TRUE, ar = 1, print.searchinfo=FALSE,engine = "fixest", cluster = "individual"))
})
Expand Down
8 changes: 5 additions & 3 deletions tests/testthat/test-7-koch-et-al.R
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@


# Prepare Data
set.seed(1230)
#data <- read.csv("CO2DriversEU_dataset.csv")
Expand Down Expand Up @@ -141,7 +143,7 @@ is3_tib <- data.frame(name = c("fesisFinland.2000",
-0.110))

test_that("Equal Breaks as in Koch et al are identified",{

skip_on_cran()
is1_tib_estimated <- data.frame(name = names(is1_coef[is1_coef < 0]),
coef = as.numeric(round(is1_coef[is1_coef < 0], 3)))

Expand All @@ -163,7 +165,7 @@ test_that("Equal Breaks as in Koch et al are identified",{


test_that("Equal Break Uncertainties as in Koch et al are identified",{

skip_on_cran()
break_is1 <- break_uncertainty( is1, interval = 0.99)
break_is2 <- break_uncertainty( is2, interval = 0.99)
break_is3 <- break_uncertainty( is3, interval = 0.99)
Expand Down Expand Up @@ -223,7 +225,7 @@ test_that("Equal Break Uncertainties as in Koch et al are identified",{


test_that("Koch et al: Standard Error Corrections",{

skip_on_cran()
is1_robust_nocluster <- robust_isatpanel(is1, cluster = FALSE)$robust
is2_robust_nocluster <- robust_isatpanel(is2, cluster = FALSE)$robust
is3_robust_nocluster <- robust_isatpanel(is3, cluster = FALSE)$robust
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-8-uis.R
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

test_that("Test that passing a uis works",{

skip_on_cran()
data(EU_emissions_road)

# Group specification
Expand Down

0 comments on commit da78531

Please sign in to comment.