Update to react-scripts 3 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes security vulnerabilities reported by npm audit and gives us latest react-scripts features and updates. Update Snapshot tests to work with latest Jest 24 required by react-scripts 3 by using the enzyme-to-json package (see jestjs/jest#7802).
|
For now I've pinned react-scripts to 3.0.1 to avoid a linting bug in 3.1.1: facebook/create-react-app#7566 Seems like the fix for that is merged and should be in next release of CRA, so we could bump the version of react-scripts then. |
dcm
reviewed
Sep 11, 2019
dcm
reviewed
Sep 11, 2019
dcm
reviewed
Sep 11, 2019
testplan/web_ui/testing/src/AssertionPane/AssertionTypes/basicAssertionUtils.js
Show resolved
Hide resolved
|
I've explicitly tested that the web UI can be isntalled, started in dev mode and built in production mode using internal npm artifactory from this branch. |
dcm
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes security vulnerabilities reported by npm audit and gives us latest
react-scripts features and updates. Update Snapshot tests to work with latest
Jest 24 required by react-scripts 3 by using the enzyme-to-json package (see
jestjs/jest#7802).
Fixes #276