Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Nov 10, 2019

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?
  • please add your name and github link to contributors.rst in alphabetical order.

@chfw chfw changed the title Override any moban file ✨ Override moban file in fs url format Nov 10, 2019
@codecov-io
Copy link

codecov-io commented Nov 10, 2019

Codecov Report

Merging #347 into dev will increase coverage by 0.22%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #347      +/-   ##
==========================================
+ Coverage   96.02%   96.24%   +0.22%     
==========================================
  Files          51       55       +4     
  Lines        2665     2795     +130     
==========================================
+ Hits         2559     2690     +131     
+ Misses        106      105       -1
Impacted Files Coverage Δ
tests/data_loaders/test_json_loader.py 100% <100%> (ø)
tests/data_loaders/test_yaml_loader.py 100% <100%> (ø)
moban/main.py 99.28% <100%> (+0.04%) ⬆️
tests/data_loaders/test_overrides.py 100% <100%> (ø)
moban/core/data_loader.py 97.18% <77.77%> (+1.94%) ⬆️
tests/data_loaders/test_merge_dict.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4563c01...a1d060f. Read the comment docs.

@chfw chfw merged commit ef6781b into dev Nov 10, 2019
@chfw chfw deleted the override-any-moban-file branch November 10, 2019 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants