Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore process working directory at end of performXMLCheck() to fix issue #179 #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dean-e-peterson
Copy link

@dean-e-peterson dean-e-peterson commented Oct 17, 2022

Attempt to fix issue #179, where a directory containing an xml file cannot be renamed or deleted after editing a contained XML file. Fix by restoring the working directory to its previous state.

Known limitations:

  • Written by a non-C/C++ developer, so string handling or something else may be wrong.
  • Does not address any other locations where the process working directory is changed with _wchdir(), such as in XmlValidation().
  • (Edit) Also does not handle if anything after the end of the method requires the process working directory to remain changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant