-
Notifications
You must be signed in to change notification settings - Fork 58
Add ProductCategoryIdent, ProductStoreDataDocument, and ProductIdentificationType URL Slug #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entificationType URL Slug, Add ProductStoreDataDocument and relationships, Add ProductCategoryIdent and relationships
Let me know if a version bump should be done. |
jonesde
requested changes
Jul 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good overall, and thank you for taking care of details like the relationships and seed data. There are a few comments, mostly about naming.
acetousk
commented
Jul 12, 2022
…warning to ProductStore's dataDocumentId field descriptions, rename storeDataDocumentTypeEnumId to storeDocumentTypeEnumId, Rename ProductStoreDataDocument Enum descriptions, rename productCategoryIdentTypeEnumId to identTypeEnumId
jonesde
approved these changes
Jul 13, 2022
Thanks Michael, looks good, merged |
amiranjom
pushed a commit
to mkdecisiondev/mantle-udm
that referenced
this pull request
Jan 26, 2023
* Release 2.2.0 changes (moqui#91) * Update XML files to use new XSD references for the 3.0.0 release series * In component.xml bump versions for upcoming release * Add more release notes from review of commits since last release, update year in AUTHORS * In README.md update last release version, add forum badge and make badges more consistent * Add URL Slug ProductIdentificationType based on discussion a while back on forum.moqui.org * Add ProductCategoryIdent, ProductStoreDataDocument, and ProductIdentificationType URL Slug (moqui#92) * Add ProductOtherIdentification relationship to Product, Add ProductIdentificationType URL Slug, Add ProductStoreDataDocument and relationships, Add ProductCategoryIdent and relationships * Rename typeEnumIds from Slug to UrlSlug for clarity, Add deprecation warning to ProductStore's dataDocumentId field descriptions, rename storeDataDocumentTypeEnumId to storeDocumentTypeEnumId, Rename ProductStoreDataDocument Enum descriptions, rename productCategoryIdentTypeEnumId to identTypeEnumId * Rename storeDocumentTypeEnumId to typeEnumId * In HumanResourceEntities move PartySkill out of commented section and add 3 entities for configuring which PartyClassifications, PartyDimension types, and PartySkill types are applicable for a EmplPosition * In WorkEffortEntities add WorkEffortParty.emplPositionId field to tracking which position that party fills on the work effort * In PartyEntities add two commented entities, might be useful but not currently used or needed for current requirements * Add WorkEffortEmplPosition join entity instead of a EmplPosition.workEffortId field that does not allow reuse of EmplPosition * Remove EmplPositionClassPartyCls entity, what was needed was really a join entity to a PartyClassificationType enum record and not the individual PartyClassification record, so replace it with a new entity EmplPositionClassPtyClsTp * Add EnumerationType for PartySkill.skillTypeEnumId and spell Reason right * Change index on Container.serialNumber from unique to a non-unique index to handle more scenarios such as the same serial number for different container types, facilities, etc * Pandor4u partycontenttype bio (moqui#94) * Adding pandor4u to Authors * Added Bio to Party Content Type seed data * Small Party seed data additions: Technical Contact role and add Owner and TechContact to the RgpAccountContact group for use as a sales account contact role * Small changes in DefaultSettings PartyAcctgPreference, more sensible/common defaults * Add PartyContentType records for invoice messages when from or to party * In GL Accounts install data add PiWireTransfer default gl account mapping, to the general checking account like most other payment methods Co-authored-by: David E. Jones <dej@dejc.com> Co-authored-by: acetousk <acetousk@users.noreply.github.com> Co-authored-by: acetousk <acetousk@gmail.com> Co-authored-by: pandor4u <103976470+pandor4u@users.noreply.github.com>
gagaboy
added a commit
to gagaboy/mantle-udm
that referenced
this pull request
Jun 10, 2023
* commit '8a45c77ca1e5f395513586ef3be0a7d9db3e3988': Add different types of contactMechPurpose for web addresses (moqui#98) Add short aliases (moqui#97) Added missing package name in entity relationship Add alias for StatusItem on EmplPosition called status (moqui#95) In GL Accounts install data add PiWireTransfer default gl account mapping, to the general checking account like most other payment methods Add PartyContentType records for invoice messages when from or to party Small changes in DefaultSettings PartyAcctgPreference, more sensible/common defaults Small Party seed data additions: Technical Contact role and add Owner and TechContact to the RgpAccountContact group for use as a sales account contact role Pandor4u partycontenttype bio (moqui#94) Change index on Container.serialNumber from unique to a non-unique index to handle more scenarios such as the same serial number for different container types, facilities, etc Add EnumerationType for PartySkill.skillTypeEnumId and spell Reason right Remove EmplPositionClassPartyCls entity, what was needed was really a join entity to a PartyClassificationType enum record and not the individual PartyClassification record, so replace it with a new entity EmplPositionClassPtyClsTp Add WorkEffortEmplPosition join entity instead of a EmplPosition.workEffortId field that does not allow reuse of EmplPosition In PartyEntities add two commented entities, might be useful but not currently used or needed for current requirements In WorkEffortEntities add WorkEffortParty.emplPositionId field to tracking which position that party fills on the work effort In HumanResourceEntities move PartySkill out of commented section and add 3 entities for configuring which PartyClassifications, PartyDimension types, and PartySkill types are applicable for a EmplPosition Add ProductCategoryIdent, ProductStoreDataDocument, and ProductIdentificationType URL Slug (moqui#92)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ProductOtherIdentification relationship to Product, Add ProductIdentificationType URL Slug, Add ProductStoreDataDocument and relationships, Add ProductCategoryIdent and relationships.
Related to:
As discussed in