Skip to content

Conversation

@andsel
Copy link
Collaborator

@andsel andsel commented Aug 10, 2025

Release notes

What does this PR do?

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the Changelog if it's a feature or a fix that has to be reported

Author's Checklist

  • Move the configuration to xml from properties, but accept both formats.

How to test this PR locally

Related issues

Use cases

@andsel andsel self-assigned this Aug 10, 2025
@hylkevds
Copy link
Collaborator

Interesting, do you have a specific reason for switching?

@andsel
Copy link
Collaborator Author

andsel commented Aug 11, 2025

do you have a specific reason for switching?

Log4j 1.x is more than outdated, also if use reload4j. However with log4j2 we could employ MDC to simplify the moving of some log context information plus we could imagine to implement a log file per session with the routing filter.

@hylkevds
Copy link
Collaborator

Ideally, the broker would only have a dependency on a logging api, not an implementation.
Currently, when embedding, a maven-exclude has to be added to get rid of the logging implementation if it doesn't fit with the implementation of the embedding application.

We could make the broker only depend on the API (either SLF4J-API or log4j-api) and have a separate maven subproject that makes moquette a runable application by adding the full logging implementation...

@andsel
Copy link
Collaborator Author

andsel commented Aug 11, 2025

This is a good point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants