fix connecting to ipv6 using quinn backend

[sirati]

currently it is not possible to connect to an Ipv6 address using quinn

the reason for this is the the Url crate converts the Ipv6 host enum variant to a string encompassed in [] i.e. [::1] however during domain name resolution it is not recognized as an ipv6 due to the [] and instead tries to look it up as if it was a domain which of course fails.

here is the code in Url that adds []

Host::Ipv6(ref addr) => {
    f.write_str("[")?;
    write_ipv6(addr, f)?;
    f.write_str("]")
}

they write they do this because of RFC 5952 A Recommendation for IPv6 Address Text Representation

that this causes problems is a known issue

here is the code in tokio that is called by this crate that handles name resolution and tries to parse the ipv6 and fails because of the []

as it is unlikely that either tokio or Url will fix this representation incompatibility i would suggest that the appropriate solution is to never convert to str and then reparse and instead only do name resolution if we are not dealing with an IP

As the host string is also passed to the connect_with function i do not know if it is appropriate to keep the [] so i am not changing that.

[kixelated]

Great fix

[sirati]

thanks for the fixes
the editor config i did not change tho?

as for the versions, for future reference: i should keep them the same for PRs as they will be automatically incremented?

[kixelated]

thanks for the fixes the editor config i did not change tho?
I made the change so it matches rustfmt defaults. It's probably not needed, I was just trying to figure out why rustfmt added line breaks.

as for the versions, for future reference: i should keep them the same for PRs as they will be automatically incremented?

They get automatically incremented by release-plz which also makes a (crude) changelog. Bumping them would have worked too.