Skip to content

Switch to aws_lc_rs#58

Merged
kixelated merged 1 commit intomainfrom
crypto-provider
Jan 15, 2025
Merged

Switch to aws_lc_rs#58
kixelated merged 1 commit intomainfrom
crypto-provider

Conversation

@kixelated
Copy link
Collaborator

And remove the sha256 crate dependency.

Fixes #56

@kixelated kixelated merged commit 03e9101 into main Jan 15, 2025
1 check passed
@kixelated kixelated deleted the crypto-provider branch January 15, 2025 05:31

rustls-platform-verifier = "0.4"
sha2 = "0.10"
rustls = "0.23"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't needed but oh well

@github-actions github-actions bot mentioned this pull request Jan 15, 2025
@nirbheek
Copy link

nirbheek commented Mar 4, 2025

Would it be possible for -quinn to use ring instead? The package is maintained again. aws_lc_rs's actual implementation is AWS-LC which is C/C++, and needs to be built using build.rs -> cmake, which fails to build on many of our configurations in GStreamer: cross-ios, cross-android, and msvc.

The original reason for switching away from sha2 was the transitive deps, but there's a lot more (unsafe!) code being pulled in with aws-lc-rs.

We've had to revert to web-transport-quinn 0.3.3 because of this.

If you need to support aws-lc-rs, maybe the switch can be behind a feature flag?

@kixelated
Copy link
Collaborator Author

Would it be possible for -quinn to use ring instead? The package is maintained again. aws_lc_rs's actual implementation is AWS-LC which is C/C++, and needs to be built using build.rs -> cmake, which fails to build on many of our configurations in GStreamer: cross-ios, cross-android, and msvc.

The original reason for switching away from sha2 was the transitive deps, but there's a lot more (unsafe!) code being pulled in with aws-lc-rs.

We've had to revert to web-transport-quinn 0.3.3 because of this.

If you need to support aws-lc-rs, maybe the switch can be behind a feature flag?

Ya I suppose a feature flag makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider reusing TLS crypto libraries for SHA2

2 participants