Conversation
|
|
||
| rustls-platform-verifier = "0.4" | ||
| sha2 = "0.10" | ||
| rustls = "0.23" |
There was a problem hiding this comment.
wasn't needed but oh well
|
Would it be possible for -quinn to use ring instead? The package is maintained again. aws_lc_rs's actual implementation is AWS-LC which is C/C++, and needs to be built using build.rs -> cmake, which fails to build on many of our configurations in GStreamer: cross-ios, cross-android, and msvc. The original reason for switching away from sha2 was the transitive deps, but there's a lot more (unsafe!) code being pulled in with aws-lc-rs. We've had to revert to web-transport-quinn 0.3.3 because of this. If you need to support aws-lc-rs, maybe the switch can be behind a feature flag? |
Ya I suppose a feature flag makes sense. |
And remove the sha256 crate dependency.
Fixes #56