fix: version fall back when package metadata is unavailable#434
Merged
Conversation
52a822a to
13d1b79
Compare
kingosticks
approved these changes
Jun 23, 2026
Member
|
I think we could consider removing |
Member
Author
|
Sure, but the problem I had is that if that is pulling from git, and we have code that calls version I get in trouble. As typically I'll setup But if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm running things with nix these days, which runs without git, which means
versionmight fail. In that case it is better to fallback to a dummy version IMO.