Browse Artists and Albums

[felixb]

Let user browse the existing/cached library.
No network IO calls done during browse.

Directory Structure:

• Google Music
  • Albums
    • Tracks
  • Artists
    • All Tracks
      • Tracks
    • Albums
      • Tracks

TODO:

• fix sorting albums, e.g. disc_no
• use _lookup_*() to reduce code duplication and show aa content

[coveralls]

Coverage decreased (-2.36%) when pulling 0e9c030 on felixb:browse-library into 5167a43 on hechtus:develop.

[felixb]

Does it make sense to use _lookup_album() here?

[abarreir]

I think it does yes. I'll let you change/test that before I merge.

[abarreir]

Looks good, although I'm not able to see all access albums under gmusic:albums or gmusic:artists:artist_id, but this is due a choice I made back when I implemented support for all access.

I'll fix that in another issue.

[felixb]

I think, this is related to my comment above. Using _lookup_*() should show even aa content.
I'll try this after finishing the browse genre thing.

[felixb]

I have another patch for browsing genres as well.
Would you like me to include it here or open a second PR?

[hechtus]

Hi, first of all, thank you for the hard work! I would suggest a new pull request for this.

[coveralls]

Coverage decreased (-2.41%) when pulling 1d4211d on felixb:browse-library into 5167a43 on hechtus:develop.

[hechtus]

Please have a look at the travis build. Always try to fix the flake8 errors. You may run flake8 on your own to check your code.

https://travis-ci.org/hechtus/mopidy-gmusic/jobs/31018034

[felixb]

Can you please help me with this one. I just don't get it:

./mopidy_gmusic/library.py:167:21: E126 continuation line over-indented for hanging indent

[hechtus]

Have a look at this: http://stackoverflow.com/questions/15435811/what-is-pep8s-e128-continuation-line-under-indented-for-visual-indent

[coveralls]

Coverage decreased (-2.41%) when pulling 1c6774b on felixb:browse-library into 5167a43 on hechtus:develop.

[lcvisser]

I can only see some albums (16 at the moment). Those ones show up fine (correct track listing, etc.), but I have many more albums in my Google Music library. Is there some limiting in effect?

[felixb]

mopidy shows a huge number of albums for me:

$ mpc ls Google\ Music/Albums | wc -l
443

[lcvisser]

$ mpc ls Google\ Music/Albums | wc -l
16

I have many more than 16. I can't find a pattern in those that are listed either: for some multi-disc albums, only one is listed, for some others all are there; for some artists only one album is listed, for some more.

[lcvisser]

Would it be better if I opened a new issue for this?

[felixb]

I'd think so. You might link this issue for better understanding.