This repository has been archived by the owner on Dec 7, 2020. It is now read-only.
Fix broken all access search #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -114,7 +114,7 @@ def get_artist_info( | |||
|
|
|||
| @endpoint(default=None, require_all_access=True) | |||
| def search_all_access(self, query, max_results=50): | |||
There was a problem hiding this comment.
This method should be renamed to search and the require_all_access kwarg set to False, ref the commit message on the gmusicapi commit that changed this, because all access was no longer required.
|
Ok, I made the requested change and it is working for me locally. |
|
Thanks! |
jodal
added a commit
that referenced
this pull request
May 19, 2016
|
this needs to be included in the PyPI package! |
|
It's included in the 2.0.0rc1 release on PyPI, which you can install by passing the |
|
Thank you very much - I should have thought of that. |
|
No, you shouldn't. It's not very obvious at all :-) I've asked in #152 if we're ready for v2.0.0 final release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #116
The gmusicapi dependency has been updated. The search_all_access() method was renamed to search(). http://unofficial-google-music-api.readthedocs.io/en/latest/reference/mobileclient.html#search.
I was able to reproduce the issue using ncmpcpp with search type of "match if tag contains searched phrase (no regexes)"
Here is the commit which caused the change. simon-weber/gmusicapi@4419d0e