Remove deprecated pkger in favor of native embed #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkger is archived in favor of embed and `go install` is no longer supported
adamdecaf
approved these changes
Dec 15, 2023
|
I updated this to what I think is a cleaner way of doing it and keeps the config and migrations in their original directories under the root. |
adamdecaf
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove pkger usage and use the native go embed instead.
Why Are Changes Being Made
pkger is archived in favor of embed and
go installis no longer supported. For some reason even when I installed pkger manually and ran the update & build from the Makefile I wasn't getting the embedded files in the binary, so figured I'd migrate this to embed instead of troubleshooting pkger.This does require moving of the migrations to
internaland adding theconfigdir withininternalas well sinceembedcan't pull from a parent directory. Can move these around a bit if there is a better suggestion.