merge from upstream #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The browser version assumes that chrome.storage.local uses an API which is compatible with localStorage; which is not the case. Even though I am using chrome.storage.local for my Chrome extension, I would much prefer to keep debug's variable in localStorage, as I consider chrome.storage.local the 'private space' of my extension. This change obviates the need to support multiple storage types. But if storage type is important, how about supporting a custom storage facility, including chrome.storage.sync? I.e. the user would provide an object that follows the conventions. Just a thought - I certainly don't see the need at this point though.
Detect 'process' package
Drop usage of `chrome.storage` (or make the storage backend pluggable)
…pt (#577) * Improve usability of Windows notes w/ examples for prompts & npm script * Made changes requested for pull request #577 (review)
* Adding TVMLKit support * removed the check for window/navigationDocument, instead relying on localStorage in the global context on all 'browser' based platforms
* instance extends feature * add .extend documentation * allow empty delimiter in extend
Signed-off-by: Outsider <outsideris@gmail.com>
feat: Add unit tests for disable return value fix: Correct spelling in test case description feat: Test that disable-string works with enable again Closes #523 docs: Add section about disable return value
Added script in package.json for running Test-suite Signed-off-by: ossdev07 <ossdev@puresoftware.com>
also removes a branch for each logging call, slightly improving performance in the browser.
s/posttest:node/coverage Explicitly call coverage only from CI. This will stop the test suite from failing on a system not configured to authenticate with circle-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.