-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emergency-para-xcm to Moonbase #2745
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfedy
added
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
labels
Apr 9, 2024
Coverage Report@@ Coverage Diff @@
## master elfedy-auto-pause-xcm +/- ##
=========================================================
+ Coverage 72.46% 72.47% +0.01%
Files 229 229
- Lines 70512 70501 -11
=========================================================
Hits 51094 51094
- Misses 19418 19407 -11
|
elfedy
requested review from
RomarQ,
librelois,
noandrea,
ahmadkaouk and
Agusrodri
April 10, 2024 15:05
elfedy
added
not-breaking
Does not need to be mentioned in breaking changes
and removed
breaking
Needs to be mentioned in breaking changes
labels
Apr 10, 2024
RomarQ
approved these changes
Apr 10, 2024
Agusrodri
approved these changes
Apr 10, 2024
This was referenced Apr 10, 2024
Added to moonriver and moonbeam in #2913 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
not-breaking
Does not need to be mentioned in breaking changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds
emergency-para-xcm
pallet to MoonbaseIs there something left for follow-up PRs?
This pallet needs to be tested properly with a flow that:
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
Moonsong-Labs/moonkit#34
Moonsong-Labs/moonkit#38
What value does it bring to the blockchain users?
This chains aims to mitigate the risk of a particular xcm halting the chain due to taking a long time to process or generating a big PoV.