Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.9.19 Dependency Update #1438

Merged
merged 44 commits into from
May 10, 2022
Merged

v0.9.19 Dependency Update #1438

merged 44 commits into from
May 10, 2022

Conversation

notlesh
Copy link
Contributor

@notlesh notlesh commented Apr 28, 2022

What does it do?

Updates our dependencies to substrate v0.9.19.

Generated update issue: #1428
Frontier branch: https://github.com/PureStake/frontier/commits/moonbeam-polkadot-v0.9.19

TODO:

@notlesh notlesh added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. dependencies Pull requests that update a dependency file labels Apr 28, 2022
@notlesh notlesh requested a review from tgmichel April 28, 2022 15:59
@librelois librelois mentioned this pull request Apr 28, 2022
16 tasks
node/service/src/lib.rs Show resolved Hide resolved
@notlesh
Copy link
Contributor Author

notlesh commented Apr 29, 2022

cargo test is failing:

error[E0308]: mismatched types
   --> pallets/parachain-staking/src/tests.rs:776:13
    |
776 |                     error: 2,
    |                            ^ expected array `[u8; 4]`, found integer

For more information about this error, try `rustc --explain E0308`.

@girazoki
Copy link
Collaborator

As I said I reviewed that the types that we changed from v0 or v1 to v2 have not changed (HeadData, Id, AccountId). But please feel free to confirm

@tgmichel
Copy link
Contributor

cargo test is failing:

error[E0308]: mismatched types
   --> pallets/parachain-staking/src/tests.rs:776:13
    |
776 |                     error: 2,
    |                            ^ expected array `[u8; 4]`, found integer

For more information about this error, try `rustc --explain E0308`.

ModuleError was changed in paritytech/substrate#10242

The legacy implementation still available in https://github.com/paritytech/substrate/blob/f4157f44220f3382d8787c3cd348e2ea7aabb048/primitives/runtime/src/legacy/byte_sized_error.rs#L29-L38

@crystalin crystalin added D2-breaksapi This PR changes public API; next release should be major. and removed B2-breaksapi labels May 10, 2022
@@ -94,7 +94,7 @@ describeDevMoonbeam("Pallet proxy - shouldn't accept removed proxy", (context) =
alith,
context.polkadotApi.tx.proxy.removeProxy(baltathar.address, "Any", 0)
);
expect(events2[4].method).to.be.eq("ExtrinsicSuccess");
expect(events2[5].method).to.be.eq("ExtrinsicSuccess");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this one changed ? This looks like a breaking change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've had to change these indices frequently, often because the ordering of the array changes (a new event is emitted, events are split into multiple ones, are combined, etc.)

I think we need a better way to express these expectations, something like "ExtrinsicSuccess" is followed by "SomeDepositEvent" but not "any error" would be awesome.

I'll try to see what caused this particular case...

@crystalin crystalin merged commit b0a0497 into master May 10, 2022
@crystalin crystalin deleted the moonbeam-polkadot-v0.9.19 branch May 10, 2022 13:55
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited D2-breaksapi This PR changes public API; next release should be major. dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants