-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify fee modifiers #1420
Closed
Closed
Unify fee modifiers #1420
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
3a6f89b
Use FixedGasPrice for transaction-payment fee modifier
notlesh c76e7ab
fmt
notlesh 7f30077
Clean up
notlesh de8286e
Merge branch 'master' into notlesh-fixed-substrate-fee-modifier
notlesh 2fae10b
Add test, remove old ones
notlesh fc15035
fmt
notlesh f903172
Remove unused code
notlesh 41b7872
Correct gas -> weight conversion
notlesh 76fb9eb
Starting point for calling query_fee_details
notlesh b4cad22
Incremental work on fees testing
notlesh d8064a4
Merge branch 'master' into notlesh-fixed-substrate-fee-modifier
notlesh 967ab7b
Fix and also break test
notlesh ed002e7
fmt
notlesh e4cd61a
Derive base_extrinsic in tests
notlesh 4a5173e
Messy test
notlesh b497e82
fmt
notlesh 75820ba
Merge branch 'master' into notlesh-fixed-substrate-fee-modifier
notlesh 24d373f
Restore missing import
notlesh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test sucks. Basically, I tried to exploit the fact that
remark
's weight fn returns its length, but after some debugging this appears to be the encoded length, not the actual remark length.#[pallet::weight(T::SystemWeightInfo::remark(_remark.len() as u32))]
The overhead increases as the remark grows in size, probably because it takes more bytes to describe the size of a larger vec.
I think the test does its job, but it's pretty ugly. I'd like to find a cleaner way to accomplish the same thing.