-
Notifications
You must be signed in to change notification settings - Fork 7
Add some Time functions #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@johnchandlerburnham I don't think the licenses belong here. What is your take on the matter? |
|
Despite I changed a lot of things in the I think that a lot of cases of copying libs to use in Formality will happen. In the MIT License, this is what made me copy the license as a code: "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." |
|
Copyright doesn't cover the essence of the idea expressed in code, only the concrete implementation. If you directly copy files, functions or text, then it needs to preserve the license, but you haven't done that here. A port is generally a derivative work which generates a fresh copyright (covered here by the root LICENSE file). I would remove the license text and just include a comment that links to the repo you were inspired by and gives credit to its author as a matter of good open source friendliness. |
|
The reason But this also doesn't type-check because it depends on U64 functions that aren't implemented on lib yet, so they can't be normalized on the type level (even though they work in JS). We need those for the type-checker to get unstuck. |
Inspired in pretty-ms and parse-ms. Converts and show time from milliseconds to days, hours, minutes, etc.
Also, add some
numbers.maxas an example of how to write the numbersneed help:
I have to improve
Time.exbut:Thedoesn't work becauseString.eqldoesn't evaluate to aBool