Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add Version property in Fare.csproj" #34

Merged
merged 1 commit into from
Apr 12, 2018

Conversation

moodmosaic
Copy link
Owner

This reverts commit 4586982. See #33 (comment).

@moodmosaic
Copy link
Owner Author

/cc @zvirja

@zvirja
Copy link
Contributor

zvirja commented Apr 9, 2018

@moodmosaic Have you checked that build script works fine at your side? :) If so, change looks completely reasonable 😀

@moodmosaic
Copy link
Owner Author

I will, once I have a .NET/C#/F# compiler in front of me.

@moodmosaic
Copy link
Owner Author

(I'm mostly inside GHC/GHCi.)

@moodmosaic
Copy link
Owner Author

Just run a build and I can confirm that the version of the assembly and the NuGet Package are obtained from the latest git tag.

@moodmosaic moodmosaic merged commit 7794152 into master Apr 12, 2018
@moodmosaic moodmosaic deleted the topic/take-out-version-property branch April 12, 2018 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants