Prepare the 'php72' branch

[scara]

PHP 7.2 is now RC5: time to prepare a branch/image for it.

Will look for the extensions required here, spare time permitted.

[scara]

Note: PHP 7.2 (now still rc, php:7.2-rc-apache) is based on Debian 9 i.e. follow microsoft/msphpsql#484 for workaround and final solution (no ETA).

[andrewnicols]

Latest update is:

No updates but it is in the plan to support it in the next RTW.

When that lands, I'll prepare the 72 branch.

[stronk7]

Ref: solr & php72: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224078

[stronk7]

With solr disabled because of the link above... I've ended with this one, all databases working ok so far (have run unit tests in mysql, pgsql, mariadb, oracle and sqlsrv).

Surely not final... but hope it will save you some time (finding libraries and other details). In fact it has helped to find https://tracker.moodle.org/browse/MDL-61240.

Just running a few more tests...

[stronk7]

TODO: Can switch to newer instaclient 12.2... (running 12.1.. now). But don't want to get distracted...

[stronk7]

(and got it passing after updating oci to 12.2 and setting library path properly)

[scara]

Great! If this will be merged:

• should it be a separate 7.2 branch i.e. still defaulting to 7.1?
• should a new issue about solr be filed to track that missing?

TIA,
Matteo

[stronk7]

should it be a separate 7.2 branch i.e. still defaulting to 7.1?

In this repo (in all in general), I'm against using the 😱 "latest" tag (de facto "default" one). So I'd keep current behavior of having to, always, specify a tag.
And I imagine that.. until solr is fixed and 7.2 works with more moodle branches... the effective default for moodle-docker compositions, can continue being 7.1 without any problem. 👍
So, summary... no changes are needed to achieve that and 7.1 will continue being picked by moodle-docker.
Only point it that I'd suggest to push this both to master (dev docker tag) and 7.2 (7.2 docker tag) branches so it becomes the base for next branches / fixes.

should a new issue about solr be filed to track that missing?

+💯

[scara]

Ref: solr & php72: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224078

That's strange: Remi repo for CentOS has that extension available since months, https://rpms.remirepo.net/enterprise/7/php72/x86_64/repoview/php-pecl-solr2.html.

I found just a mention about Stretch long time ago, oerdnj/deb.sury.org#664 (comment): what about dropping a new issue there to know where we actually are in Debian 9 for solr and PHP 7.2?

Edit: it is there as a package, https://packages.sury.org/php/dists/stretch/main/binary-amd64/Packages:

Package: php-solr
Version: 2.4.0-5+0~20170908051553.2+stretch~1.gbpd2bc7d
Architecture: amd64
Maintainer: Debian PHP PECL Maintainers <pkg-php-pecl@lists.alioth.debian.org>
Installed-Size: 1271
Depends: php-curl, php-common (>= 1:7.0+33~), phpapi-20170718 | phpapi-20160303 | phpapi-20151012 | phpapi-20131226, libc6 (>= 2.14), libcurl3 (>= 7.16.2), libxml2 (>= 2.7.4)
Provides: php5.6-solr, php7.0-solr, php7.1-solr, php7.2-solr
Homepage: http://pecl.php.net/package/solr
Priority: optional
Section: php
Filename: pool/main/p/php-solr/php-solr_2.4.0-5+0~20170908051553.2+stretch~1.gbpd2bc7d_amd64.deb
Size: 170352
SHA256: bdbde09baa6ed2669d1307c71a54b0a05bff436ae90e2cafbbf27dcf13ca3617
SHA1: 4b38caf5c85ccad488ab573eda56cd92457fca99

Nothing has been filed into https://github.com/docker-library/php - found the fix by Remi: https://git.php.net/?p=pecl/search_engine/solr.git;a=commitdiff;h=744e32915d5989101267ed2c84a407c582dc6f31 (php/pecl-search_engine-solr@744e329) - and if I give it a try on an plain 7.2-apache container instance it breaks on something that looks like already fixed by Remi but not in the main repo, https://bugs.php.net/bug.php?id=75631.

Edit^2: added a proposal in stronk7@aaf7d05#r27038188, to enable solr and then track the availability of a new official pecl version in a separate issue, here.

HTH,
Matteo