Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MySQL default to 8.0 and PostgreSQL to 13. And PHP defaults to 8.0 #245

Merged
merged 3 commits into from
Dec 24, 2022

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Dec 17, 2022

NOT TO BE MERGED YET!

They are the lowest versions supported for 4.2 and up.

Note that, at the time of writing this that's just a proposal, but that
way we can test if they work for all supported branches in advance.

So, here, we make MySQL 8.0 the default and create specific versions
for 5.6 and 5.7 in case anybody wants to use them.

Also, update GHA workflow to cover the new 401_STABLE branch and
update the master runs to use exclusively php80 (php81 will be added
once the branch is ready).

Finally, and not less important, change the default PHP version from 7.4 to 8.0. All
current supported versions support 8.0 (but 39_STABLE) and this can
be easily changed with MOODLE_DOCKER_PHP_VERSION.

Note this is on hold until MDL-74905 - Moodle 4.2 requirements is agreed.

@stronk7 stronk7 changed the title Bump MySQL default to 8.0 and PostgreSQL to 13 Bump MySQL default to 8.0 and PostgreSQL to 13. And PHP defaults to 8.0 Dec 17, 2022
They are the lowest versions supported for 4.2 and up.

Note that, at the time of writing this that's just a proposal, but that
way we can test if they work for all supported branches in advance.

So, here, we make MySQL 8.0 the default and create specific versions
for 5.6 and 5.7 in case anybody wants to use them.
Note that some runs have been updated to use php 8.1 but they
have been commented, to be enabled once php 8.1 support is ready.
It works in all currently supported branches (but 39_STABLE that
needs 7.4). But it's time to do so.

I always can be changed using MOODLE_DOCKER_PHP_VERSION, so not
big problem expected.
@stronk7 stronk7 force-pushed the bump_mysql_pgsql_moodle_42 branch from a94bc51 to 9f91e11 Compare December 17, 2022 18:14
@stronk7
Copy link
Member Author

stronk7 commented Dec 24, 2022

As far as it seems that all the proposed changes for Moodle 4.2 are going to be accepted @ MDL-74905... applying them here a little bit in advance.

Ciao :-)

@stronk7 stronk7 merged commit 0c28e95 into moodlehq:master Dec 24, 2022
@stronk7 stronk7 deleted the bump_mysql_pgsql_moodle_42 branch December 24, 2022 14:30
@scara
Copy link
Contributor

scara commented Dec 25, 2022

Hi @stronk7,
is there any reason to re-add db.mysql.5.6.yml?
Ref: #225 (comment)

HTH,
Matteo

@stronk7
Copy link
Member Author

stronk7 commented Dec 25, 2022

My only point was that the previous default db.mysql.yml supported both MySQL 5.6 and 5.7, and then the specific db.mysql.8.0.yml was, obviously, for MySQL 8.0

So, when making in this PR the 8.0 to become the default, we needed to continue supporting the 5.6 and 5.7 ones and that only can be done providing specific files for each (no matter they are 100% the same). Without them, they are sort of "unreachable" now.

Note that only Moodle 3.9.x (within the currently supported Moodle versions), supports MySQL 5.6. But until 3.9 falls out of support, it cannot hurt to keep it working, I think.

Ciao :-)

@scara
Copy link
Contributor

scara commented Dec 26, 2022

Hi @stronk7,

Note that only Moodle 3.9.x (within the currently supported Moodle versions), supports MySQL 5.6. But until 3.9 falls out of support, it cannot hurt to keep it working, I think.

Thanks for taking the time to highlight the key point I was missing 💪 .

Ciao,
Matteo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants