-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Singularise plurals #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnicols
force-pushed
the
singularisePlurals
branch
from
July 19, 2023 01:54
b45c9db
to
76a657b
Compare
Complete runs for phpunit and behat against master:
|
andrewnicols
force-pushed
the
singularisePlurals
branch
from
July 19, 2023 02:01
76a657b
to
3f23a63
Compare
This commit adds new endpoints to /backoffice for: - /rooms - get all rooms with all room memberships - /create - create a set of data to be used in testing
andrewnicols
force-pushed
the
singularisePlurals
branch
from
July 19, 2023 03:37
3f23a63
to
dba7088
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The convention in Moodle, Symfony, and pretty much everywhere really, is to use singular names for tables because each row is an instance of that thing and makes your code more meaningful to read, for example:
Is this person a users or user?
compare with:
You also have a
UserRepository
rather than aUsersRepository
because it contains a collection of user objects.This very simple change just renames all tables to be in the singular.
It is built on top of #3.