Consolidate packages and migrate installation to demo app #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before migrations have been applied, this will error
evnsio
approved these changes
Jul 15, 2019
|
@milesbxf would it be possible to include an example in the demo app for how consumers would be able to register additional handlers/commands? |
|
@AshleyPoole yes, that's a great idea 👍 would you be able to raise that as an issue/feature request? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR number 2 to resolve #33 . This includes #56 , so review that one first
This combines the
core,pagerdutyandslackapps into a singleresponseapp. Users will now only need to add'response.apps.ResponseConfig'to theirINSTALLED_APPSto get core functionality.I decided to leave the UI app separate, though move it to
response/uito avoid potential conflict with other Django plugins someone might have installed - this should keep it easy to customise.This moves the Django installation and
docker-composeshim into a newdemofolder, which is intended as an example of how to set up response and allow someone to play around with it.Todo: