Add disableInstrumentation option #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you ok with the PR? |
skeetmtp
force-pushed
the
disable-instrumentation2
branch
2 times, most recently
from
718e89d
to
7ecb15c
Compare
Useful when you want to fully disable instrumentation overhead without remove the package
skeetmtp
force-pushed
the
disable-instrumentation2
branch
from
7ecb15c
to
6d14636
Compare
|
up |
|
+1 for an option to disable instrumentation |
|
@zodern any chance you can merge it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful when you want to fully disable instrumentation overhead without remove the package
Our need:
With one of our app, node process memory increase a lot when monti packages are added
Issue is a bit mitigated by
"documentSizeCacheSize": 10000
But still, memory usage is quite above normal
We would like to disable monti for this cron meteor app, as it is a cron with no real front, so monti is not as effective as it is on a front app.
unfortunately, as we are mono repo, plus, we actually release a single app, but deploys with different Meteor.settings
so, an app behave differently depending on the settings
Thus, if we remove monti apm for the cron, this will remove it for all our apps, fronts included :/
disableInstrumentation settings, would be great addition for our use case