Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow undefined arguments to be passed to Object.assign #2007

Merged
merged 2 commits into from
Feb 5, 2019

Conversation

tejaede
Copy link
Collaborator

@tejaede tejaede commented Feb 4, 2019

Object.assign() should not throw if given undefined or null arguments, per MDN. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign (last line of description section as of this writing)

his PR updates the object polyfill accordingly.

@tejaede tejaede requested a review from marchant February 4, 2019 23:53
@tejaede tejaede self-assigned this Feb 4, 2019
core/shim/object.js Outdated Show resolved Hide resolved
@marchant marchant merged commit ad7e919 into master Feb 5, 2019
@cdebost cdebost deleted the bugs/object-assign-shim branch February 7, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants