Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major refactoring of development and continuous integration scripts, fixes #294 #295

Merged
merged 6 commits into from
Oct 30, 2018

Conversation

erikbarke
Copy link
Collaborator

@erikbarke erikbarke commented Oct 17, 2018

This PR adds support for installing example and integration projects using npm 6.x.

Pros:

  • All scripts will be located in package.json
  • No more confusing ping pong between Gulp, shell scripts and npm scripts
  • Fewer dependencies, gulp, copy, cross-spawn etc are gone
  • package.json in the example projects are a lot cleaner, no more ci stuff
  • Improved performance on the ci servers, npm 6.x installs each project way faster than 3.x
  • Failed builds on the ci servers now actually halts the build, marking it as failed
  • As a bonus side effect, the karma-typescript package published on npm will only contain dist, package.json and licenses

Cons:

  • Developing probably only works using newer versions of npm, I haven't been able to test older versions of npm
  • This must be released in 4.0.0, because it also changes what goes into the karma-typescript package published on npm, could be a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant