Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor docs for i2c2midi #307

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Conversation

attowatt
Copy link
Contributor

What does this PR do?

Updates the documentation for i2c2midi OPs:

  • Added better information about the behavior of MIDI channels (using channel-specific OPs vs normal OPs)
  • Added hint to use ch = 0 to make a setting for all MIDI channels
  • Added allowed range of channel parameter for channel-specific OPs
  • Fixed some typos

Provide links to any related discussion on lines.

How should this be manually tested?

Any background context you want to provide?

If the related Github issues aren't referenced in your commits, please link to them here.

I have,

  • updated CHANGELOG.md and whats_new.md
  • updated the documentation
  • updated help_mode.c (if applicable)
  • run make format on each commit
  • run tests

@scanner-darkly scanner-darkly merged commit 7d0ea32 into monome:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants