Adding fix for # bug #299
Merged
Adding fix for # bug #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scanner-darkly
approved these changes
Jan 21, 2023
|
thank you for fixing this! |
|
going to merge this as i need to open a PR that relies on this fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes bug where # in a command would cause scene restore to fail.
Provide links to any related discussion on lines.
How should this be manually tested?
NB: Needs testing on hardware TT. Ive tested it only on an alt firmware.
Any background context you want to provide?
If the related Github issues aren't referenced in your commits, please link to them here.
I have,
CHANGELOG.mdandwhats_new.mdhelp_mode.c(if applicable)make formaton each commit