support for expert sleepers disting ex #88
Conversation
|
|
||
| static void ii_tr_disting_ex(i2c_follower_t* follower, uint8_t track, uint8_t state) { | ||
| uint8_t d[4] = { 0 }; | ||
| s16 note = calculate_note(dac_get_value(track), follower->oct); |
There was a problem hiding this comment.
This reminds me that sending the current dac_get_value is potentially out of tune if the user has a custom tuning table saved to correct for the module's DAC offsets. The JF trigger function does the same thing. I think it's not a huge deal right now but we should maybe have another issue to buffer the requested semitone value for each track -- this would also let you skip the reverse pitch -> note calculation.
There was a problem hiding this comment.
yeah, i think it would be useful if we stored the note id in addition to pitch. additionally, i think we should also store the DAC value without the calibration offsets applied, if we decide to support microtonal scales at some point.
|
i think a couple of things remaining on @csboling's list? |
|
Yeah, I'm waiting on some user feedback for #23 and JF 4.0 has some issues with the note tying change. These have both been outstanding quite a long time, would be nice to get them in. I think a number of Teletype changes are still in the works, if we want to synchronize releases. |
added disting ex as a supported follower device.
since it has 4 modes, i had to shift the top right section for mode selection left by 1 button.