This repository was archived by the owner on Oct 1, 2024. It is now read-only.
[nuget] use $(PackageLicenseExpression), not $(PackageLicenseUrl) #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dellis1972
approved these changes
Mar 31, 2022
Contributor
dellis1972
left a comment
dellis1972
left a comment
There was a problem hiding this comment.
Can we bump the version number in this commit too? We can then start a publish
Context: https://docs.microsoft.com/en-us/nuget/reference/nuspec#licenseurl Context: https://docs.microsoft.com/en-us/nuget/reference/nuspec#license Context: https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/nuget#important-nuget-package-metadata Context: https://docs.clearlydefined.io/curation-guidelines Certain internal Microsoft tools check NuGet license information by using [ClearlyDefined curated data][0] to determine verified license information for packages which don't "clearly define" their license. Unfortunately, a license URL is *not* considered "clearly defined", likely because it isn't *really* machine readable. (Just because the URL contains "MIT" doesn't mean it's *actually* MIT.) As part of this effort, [NuGet deprecated][1] the [`<licenseUrl/>`][2] element, and MSBuild deprecated the [`$(PackageLicenseUrl)`][3] MSBuild property. The NuGet [`<license/>`][4] element or [`$(PackageLicenseExpression)` MSBuild property][5] should be used. Replace `$(PackageLicenseUrl)` with `$(PackageLicenseExpression)`, with a value of `MIT AND BSD-3-Clause`. The value needs to be an [SPDX identifier][6], and as OpenTK contains both MIT and 3-clause BSD license text within `Documentation/Licennse.txt`, using the `AND` expression feels appropriate. This change should satisfy ClearlyDefined. Update `$(_OpenTKNugetVersion)` to 1.0.2. [0]: https://github.com/clearlydefined/curated-data/ [1]: NuGet/Home#7509 [2]: https://docs.microsoft.com/en-us/nuget/reference/nuspec#licenseurl [3]: https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets#pack-target [4]: https://docs.microsoft.com/en-us/nuget/reference/nuspec#license [5]: https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets#packing-a-license-expression-or-a-license-file [6]: https://spdx.org/licenses/
jonpryor
force-pushed
the
jonp-add-license-expression
branch
from
51794dc to
2ae1a5d
Compare
Contributor
Author
|
@dellis1972: version number bumped. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://docs.microsoft.com/en-us/nuget/reference/nuspec#licenseurl
Context: https://docs.microsoft.com/en-us/nuget/reference/nuspec#license
Context: https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/nuget#important-nuget-package-metadata
Context: https://docs.clearlydefined.io/curation-guidelines
Certain internal Microsoft tools check NuGet license information by
using ClearlyDefined curated data to determine verified license
information for packages which don't "clearly define" their license.
Unfortunately, a license URL is not considered "clearly defined",
likely because it isn't really machine readable. (Just because the
URL contains "MIT" doesn't mean it's actually MIT.)
As part of this effort, NuGet deprecated the
<licenseUrl/>element, and MSBuild deprecated the
$(PackageLicenseUrl)MSBuild property. The NuGet
<license/>element or$(PackageLicenseExpression)MSBuild property should be used.Replace
$(PackageLicenseUrl)with$(PackageLicenseExpression),with a value of
MIT AND BSD-3-Clause. The value needs to be anSPDX identifier, and as OpenTK contains both MIT and 3-clause
BSD license text within
Documentation/Licennse.txt, using theANDexpression feels appropriate.This change should satisfy ClearlyDefined.