This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[MagTek.iDynamo] Fix up native library slices #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migueldeicaza
added a commit
that referenced
this pull request
Mar 9, 2015
[MagTek.iDynamo] Fix up native library slices
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the downloaded zip contents changed at some point, but retained the same file name? Not sure what happened, really.
The native library no longer contains an ARMv6 slice, so I removed that from the binding.
The native library now contains an ARMv7s slice, so I added that to the binding.
I also added a slice to support the simulator. I guess it could be argued that this library is useless in the simulator, but I didn't like having the build warning.
The "ARMv7 support" section of the ReadMe is no longer applicable, so I removed it.