Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

Bump Roslyn to 3.3.0-beta2-19401-05 #8332

Merged
merged 2 commits into from
Aug 7, 2019

Conversation

ryzngard
Copy link
Contributor

@ryzngard ryzngard commented Aug 2, 2019

Changes since e4e7c09:

@ryzngard
Copy link
Contributor Author

ryzngard commented Aug 2, 2019

@sandyarmstrong

@sandyarmstrong sandyarmstrong self-assigned this Aug 2, 2019
@sandyarmstrong
Copy link
Member

sandyarmstrong commented Aug 2, 2019

/Users/vsts/agent/2.155.1/work/1/s/monodevelop/main/external/fsharpbinding/MonoDevelop.FSharpBinding/Services/RoslynHelpers.fs(10,19): error FS0366: No implementation was given for 'CodeAnalysis.ISymbol.Equals(other: CodeAnalysis.ISymbol, equalityComparer: CodeAnalysis.SymbolEqualityComparer) : bool'. Note that all interface members must be implemented and listed under an appropriate 'interface' declaration, e.g. 'interface ... with member ...'. [/Users/vsts/agent/2.155.1/work/1/s/monodevelop/main/external/fsharpbinding/MonoDevelop.FSharpBinding/MonoDevelop.FSharp.fsproj]

Caused by https://github.com/dotnet/roslyn/pull/37247/files#diff-97e6c7b4bcf3ab5bec94f26ae36c1d71

@Therzok
Copy link
Contributor

Therzok commented Aug 3, 2019

We should also have this in 8.3

@sandyarmstrong
Copy link
Member

sandyarmstrong commented Aug 3, 2019

release-8.3 is still getting regular merges from master. If that stops before this PR merges, I'll be sure to backport.

That being said, there is work to do before we can merge this. Some QuickInfo changes (dotnet/roslyn#35667) have landed and the editor needs to deal with them properly. Right now everything is too linkified in appearance:

image

To make matters worse, sometimes for no reason I can immediately discern, it looks even more linkified:

image

Additionally, none of the underlined text inside of QuickInfo functions as a link. You can right click and there is an "open link" option, but nothing happens. EDIT: I was wrong about this, it seems. The links do seem to work in the VSmac build.

Next week I'll look into what needs to be done in the editor/monodevelop, and whether or not any of these are Roslyn bugs. But we can't take this bump until it's all sorted out.

@sandyarmstrong sandyarmstrong force-pushed the pr-ryzngard-roslyn-3.3.0-beta2-19401-05 branch from a65234b to 622366f Compare August 6, 2019 17:26
@sandyarmstrong
Copy link
Member

For now, we've disabled linkification of most elements in QuickInfo. We'll bring this back after we can devote time to make the UI behave the way we want.

@sandyarmstrong sandyarmstrong added Roslyn: Approved for merge Roslyn team has verified and approved this build and removed Roslyn: Needs sign-off Do not merge until Roslyn team approves labels Aug 7, 2019
@sandyarmstrong sandyarmstrong force-pushed the pr-ryzngard-roslyn-3.3.0-beta2-19401-05 branch from 622366f to 7f4850d Compare August 7, 2019 03:15
@sandyarmstrong sandyarmstrong merged commit fe73a6e into master Aug 7, 2019
@sandyarmstrong sandyarmstrong deleted the pr-ryzngard-roslyn-3.3.0-beta2-19401-05 branch August 7, 2019 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Roslyn Integration Roslyn: Approved for merge Roslyn team has verified and approved this build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants