This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Convert Timeout/Idle.Handler method from instance to static, so it's … #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not JITed on every Application.Invoke If method is instance instead of static every time it's passed as delegate to unmanaged code runtime(mono) needs to JIT it since "this" is part of JITed method, with this change JITing doesn't need to be performed anymore
|
LGTM. |
| @@ -32,7 +32,7 @@ namespace GLib { | |||
| public class Idle { | |||
|
|
|||
| [UnmanagedFunctionPointer (CallingConvention.Cdecl)] | |||
| delegate bool IdleHandlerInternal (); | |||
| delegate bool IdleHandlerInternal (IntPtr ptr); | |||
There was a problem hiding this comment.
Why does this take an IntPtr, when the proxyId is an int?
There was a problem hiding this comment.
Oh, looks like the native counterpart takes a long.
There was a problem hiding this comment.
I'm pretty sure native counterpart is taking pointer, hence IntPtr...
In theory this should be used to store pointer to data object, but int is enough for our use case...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…not JITed on every Application.Invoke
If method is instance instead of static every time it's passed as delegate to unmanaged code runtime(mono) needs to JIT it
since "this" is part of JITed method, with this change JITing doesn't need to be performed anymore