[perf] Fixed PerfWatson in Mono.Debugger.Soft.Connection.disconnected_check #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_check With another recent PerfWatson fix (mono@824fc62), a lock has been introduced in the disconnected_check method, to mostly control the access of the disconnected property. This caused a new PerfWatson issue, so this change reverts that extra threading control and instead converts the disconnected boolean variable into a volatile variable, so the latest updated value is always guaranteed for multi threading access, without the need of an unnecessary and blocking lock. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2481686/?view=edit
thaystg
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With another recent PerfWatson fix (824fc62), a lock has been introduced in the disconnected_check method, to mostly control the access of the disconnected property. This caused a new PerfWatson issue, so this change reverts that extra threading control and instead converts the disconnected boolean variable into a volatile variable, so the latest updated value is always guaranteed for multi threading access, without the need of an unnecessary and blocking lock.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2481686/?view=edit