Open
Conversation
- update the bundled Skia revision and version metadata to m133\n- link jsonreader for native Apple/Tizen builds and regenerate bindings\n- expose CreateCicp on SKColorSpace and keep stream ownership tests green\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
📦 Try the packages from this PRWarning Do not run these scripts without first reviewing the code in this PR. Step 1 — Download the packages bash / macOS / Linux: curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 3660PowerShell / Windows: iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 3660"Step 2 — Add the local NuGet source dotnet nuget add source ~/.skiasharp/hives/pr-3660/packages --name skiasharp-pr-3660More options
Or download manually from Azure Pipelines — look for the Remove the source when you're done: dotnet nuget remove source skiasharp-pr-3660 |
|
📖 Documentation Preview The documentation for this PR has been deployed and is available at: 🔗 View Staging Site This preview will be updated automatically when you push new commits to this PR. This comment is automatically updated by the documentation staging workflow. |
The m133 update does not require the HandleDictionary type-mismatch adjustment, so drop it from this PR to keep the scope limited.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pick up the Skia submodule fix for the strict_aliasing merge regression, keep the unused delaunator-cpp DEPS entry disabled, and align cgmanifest's mono/skia commitHash with the vendored submodule commit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the narrower HandleDictionary behavior for plain GetInstance lookups so handle-type mismatches and unknown wrapper types return false instead of throwing during ownership/GC scenarios, while GetOrAddObject remains strict for construction paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsonreadermodule for native Apple/Tizen builds and regenerate the bindingsSKColorSpace.CreateCicp(...)and keep the stream ownership tests green after the updateRelated