Open
Conversation
Update Skia from m132 to m133. Changes: - Update submodule to dev/update-skia-m133 branch - Regenerate SkiaApi.generated.cs (SkPngEncoder gains gainmap fields) - Update VERSIONS.txt and cgmanifest.json for m133 - Add -ljsonreader to Apple and Tizen link configs (SkJSON moved to modules/jsonreader in m133) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
📦 Try the packages from this PRWarning Do not run these scripts without first reviewing the code in this PR. Step 1 — Download the packages bash / macOS / Linux: curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 3659PowerShell / Windows: iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 3659"Step 2 — Add the local NuGet source dotnet nuget add source ~/.skiasharp/hives/pr-3659/packages --name skiasharp-pr-3659More options
Or download manually from Azure Pipelines — look for the Remove the source when you're done: dotnet nuget remove source skiasharp-pr-3659 |
|
📖 Documentation Preview The documentation for this PR has been deployed and is available at: 🔗 View Staging Site This preview will be updated automatically when you push new commits to this PR. This comment is automatically updated by the documentation staging workflow. |
Restore intentional iOS GrGLMakeNativeInterface platform patch that was incorrectly overwritten during m133 merge. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
6584fa4 to
28a0395
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Skia from milestone 132 to 133.
Depends on: mono/skia PR (link below — must be merged first to update submodule)
🔗 mono/skia PR: mono/skia@skiasharp...dev/update-skia-m133
Changes
Submodule & Versions
externals/skiasubmodule todev/update-skia-m133branchscripts/VERSIONS.txt: milestone 132→133, all version numberscgmanifest.json: commit hash, chrome_milestone, upstream_merge_commitRegenerated Bindings
binding/SkiaSharp/SkiaApi.generated.cs: AddedfGainmapandfGainmapInfofields toSKPngEncoderOptionsstruct (matching upstreamSkPngEncoder::Optionschange)Platform Build Configs
-ljsonreaderto Apple Xcode projects (macOS, iOS, tvOS) — upstream movedSkJSONtomodules/jsonreaderin m133jsonreaderto Tizenproject_def.proplink librariesBreaking Changes Handled (m132 → m133)
SkJSON.h→modules/jsonreader/SkJSONReader.hSkPngEncoder::Optionsgained gainmap fields-fstrict-aliasingextracted to GN configSkMaskFilter::approximateFilteredBoundsremovedGrContextOptionsfields reorderedTesting