Skip to content

Bump skia to milestone 133 (Opus 4.6)#3659

Open
mattleibow wants to merge 2 commits intomainfrom
mattleibow/dev-update-skia-m133
Open

Bump skia to milestone 133 (Opus 4.6)#3659
mattleibow wants to merge 2 commits intomainfrom
mattleibow/dev-update-skia-m133

Conversation

@mattleibow
Copy link
Copy Markdown
Contributor

Summary

Update Skia from milestone 132 to 133.

Depends on: mono/skia PR (link below — must be merged first to update submodule)

🔗 mono/skia PR: mono/skia@skiasharp...dev/update-skia-m133

Changes

Submodule & Versions

  • Updated externals/skia submodule to dev/update-skia-m133 branch
  • Updated scripts/VERSIONS.txt: milestone 132→133, all version numbers
  • Updated cgmanifest.json: commit hash, chrome_milestone, upstream_merge_commit

Regenerated Bindings

  • binding/SkiaSharp/SkiaApi.generated.cs: Added fGainmap and fGainmapInfo fields to SKPngEncoderOptions struct (matching upstream SkPngEncoder::Options change)

Platform Build Configs

  • Added -ljsonreader to Apple Xcode projects (macOS, iOS, tvOS) — upstream moved SkJSON to modules/jsonreader in m133
  • Added jsonreader to Tizen project_def.prop link libraries

Breaking Changes Handled (m132 → m133)

Change Risk Action
SkJSON.hmodules/jsonreader/SkJSONReader.h 🔴 Updated include + link configs
SkPngEncoder::Options gained gainmap fields 🔴 Updated C struct + regenerated
-fstrict-aliasing extracted to GN config 🔴 Added config blocks in skia
SkMaskFilter::approximateFilteredBounds removed 🟢 Not wrapped — no action
GrContextOptions fields reordered 🟢 Field-by-field copy — no action

Testing

  • ✅ Native build succeeds (macOS arm64)
  • ✅ C# build succeeds (0 errors)
  • ✅ 5,369 tests passed, 12 skipped (no GPU hardware), 1 flaky GC test (passes on retry)

Update Skia from m132 to m133.

Changes:
- Update submodule to dev/update-skia-m133 branch
- Regenerate SkiaApi.generated.cs (SkPngEncoder gains gainmap fields)
- Update VERSIONS.txt and cgmanifest.json for m133
- Add -ljsonreader to Apple and Tizen link configs (SkJSON moved to
  modules/jsonreader in m133)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

📦 Try the packages from this PR

Warning

Do not run these scripts without first reviewing the code in this PR.

Step 1 — Download the packages

bash / macOS / Linux:

curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 3659

PowerShell / Windows:

iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 3659"

Step 2 — Add the local NuGet source

dotnet nuget add source ~/.skiasharp/hives/pr-3659/packages --name skiasharp-pr-3659
More options
Option Description
--successful-only / -SuccessfulOnly Only use successful builds
--force / -Force Overwrite previously downloaded packages
--list / -List List available artifacts without downloading
--build-id ID / -BuildId ID Download from a specific build

Or download manually from Azure Pipelines — look for the nuget artifact on the build for this PR.

Remove the source when you're done:

dotnet nuget remove source skiasharp-pr-3659

@mattleibow mattleibow changed the title Bump skia to milestone 133 Bump skia to milestone 133 (Opus 4.6) Apr 10, 2026
github-actions bot pushed a commit that referenced this pull request Apr 10, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

📖 Documentation Preview

The documentation for this PR has been deployed and is available at:

🔗 View Staging Site
🔗 View Staging Docs
🔗 View Staging Gallery

This preview will be updated automatically when you push new commits to this PR.


This comment is automatically updated by the documentation staging workflow.

Restore intentional iOS GrGLMakeNativeInterface platform patch that was
incorrectly overwritten during m133 merge.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mattleibow mattleibow force-pushed the mattleibow/dev-update-skia-m133 branch from 6584fa4 to 28a0395 Compare April 10, 2026 21:22
github-actions bot pushed a commit that referenced this pull request Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant