Upgrade SkiaSharp major version from 3.x to 4.x#3640
Open
mattleibow wants to merge 5 commits intomainfrom
Open
Upgrade SkiaSharp major version from 3.x to 4.x#3640mattleibow wants to merge 5 commits intomainfrom
mattleibow wants to merge 5 commits intomainfrom
Conversation
Update all example/documentation version references in skill SKILL.md and reference files to reflect the new 4.x major version. Historical version references (3.116.x, 2.88.x) used as comparison baselines are preserved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Update VERSIONS.txt: assembly 4.119.0.0, file 4.119.4.0, all nuget 4.119.4 - Update azure-templates-variables.yml: SKIASHARP_MAJOR_VERSION=4, SKIASHARP_VERSION=4.119.4 - Update samples/_UnoPlatformSamples.targets: package versions to 4.119.0 - Update build.cake: SkiaSharp.Views.Gtk4 minimum version to 4.119.0 - Fix update-versions.ps1: use dynamic major version detection instead of hardcoded '3' - Fix building-samples.md: use SkiaSharp.[0-9]* glob pattern instead of SkiaSharp.3* - Update all doc examples from 3.119.x to 4.119.x Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- _UnoPlatformSamples.targets: read SkiaSharp/HarfBuzzSharp versions from scripts/VERSIONS.txt at build time instead of hardcoding them (eliminates 14 hardcoded version references) - azure-templates-variables.yml: add comment explaining these must be kept in sync with VERSIONS.txt (can't be dynamic due to CI counter) - building-samples.md: use X.Y.Z placeholders instead of specific version numbers in examples - adding-libraries.md: use X.Y.Z placeholder in example - detect-preview-version.ps1: use generic version in comment - integration test csproj: use generic version in comment Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
📦 Try the packages from this PRWarning Do not run these scripts without first reviewing the code in this PR. Step 1 — Download the packages bash / macOS / Linux: curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 3640PowerShell / Windows: iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 3640"Step 2 — Add the local NuGet source dotnet nuget add source ~/.skiasharp/hives/pr-3640/packages --name skiasharp-pr-3640More options
Or download manually from Azure Pipelines — look for the Remove the source when you're done: dotnet nuget remove source skiasharp-pr-3640 |
Only keep functional changes — version examples in skill docs and documentation don't need to match the actual current version. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
_UnoPlatformSamples.targets uses old versions intentionally for testing. build.cake SUPPORTED_NUGETS tracks the minimum version a package first existed — not the current version. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps SkiaSharp's major version from 3.119.x to 4.119.x and makes version references more maintainable for future bumps.
Version bump (3 → 4)
scripts/VERSIONS.txt— Assembly4.119.0.0, file4.119.4.0, all 30 NuGet packages →4.119.4scripts/azure-templates-variables.yml—SKIASHARP_MAJOR_VERSION: 4,SKIASHARP_VERSION: 4.119.4build.cake—SkiaSharp.Views.Gtk4minimum version →(4, 119, 0)3.119.xto4.119.xFuture-proofing (reduce work for next major bump)
samples/_UnoPlatformSamples.targets— Now reads SkiaSharp/HarfBuzzSharp versions dynamically fromVERSIONS.txtat build time instead of hardcoding them (eliminates 14 hardcoded refs)update-versions.ps1— Uses dynamic major version detection instead of hardcoded3.building-samples.md— UsesSkiaSharp.[0-9]*glob pattern instead ofSkiaSharp.3*, andX.Y.Zplaceholders in examplesX.Y.Zplaceholders where possibleFor the next major bump (4→5), only 2 files need updating:
scripts/VERSIONS.txt(source of truth)scripts/azure-templates-variables.yml(CI counter requires compile-time value)Verified
dotnet cake --target=externals-downloadsucceededdotnet build binding/SkiaSharp/SkiaSharp.csproj— 0 errors, assembly version =4.119.0.0dotnet pack— producesSkiaSharp.4.119.4.nupkg3.119references remain (changelogs excluded as historical records)