Conversation
|
@dotnet-policy-service agree |
There was a problem hiding this comment.
Pull request overview
This PR updates the CsWinRT dependency in the WinUI native projection project to a newer version intended to resolve trimming-safety warnings when using NativeAOT, addressing issue #3327.
Changes:
- Bump
Microsoft.Windows.CsWinRTpackage reference from2.0.4to2.2.0inSkiaSharp.Views.WinUI.Native.Projection.csproj. - No code or API changes; only build/dependency configuration is updated.
|
Thansk for this PR! I triggered the build internally and I see we are getting an error:
|
|
Oh, I finally reproduced this build error. It is quite painful to prepare the environment since lots of stuffs are updated. For example, I ran into llvm/llvm-project#95133 when trying to build It seems like it is related to code generation. I need some time to check whether I can fix it here or we need to wait for bug fix from CsWinRT. |
6b53ed4 to
c40ec6a
Compare
|
@mattleibow Hello, I can now build But I'm a little bit concerned about what if users of SkiaSharp use an old version. By the way, I only made |
c40ec6a to
ae9374f
Compare
Description of Change
Version Update to make
SkiaSharp.Views.WinUI.Native.Projectiontrimming-safeBugs Fixed
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist