Skip to content

Conversation

@mattleibow
Copy link
Contributor

@mattleibow mattleibow commented May 26, 2023

Description of Change

This PR adds the arm64 architecture for iOS simulators.

Because there is now both a device and a simulator arm64, we have to split the framework into separate files. It is possible to use xcframeworks, however there was some issues with it working with iOS Hot Restart (iPhone plugged into Windows directly) and also the current build does not do that. The simplest is to just have 2 frameworks and switch them out depending on the runtime identifier.

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Build fails for iossimulator-arm64

2 participants