Skip to content

Conversation

@jeromelaban
Copy link
Contributor

@jeromelaban jeromelaban commented May 16, 2022

This PR supersedes #1960.

Description of Change

Added views for Uno.WinUI #1787

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@jeromelaban jeromelaban marked this pull request as ready for review May 17, 2022 17:54
Copy link
Contributor

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good.

Just need the nuget stuff:

  • .nusepc
  • version in VERSIONS.txt
  • entry in TRACKED_NUGETS in build.cake

@jeromelaban jeromelaban marked this pull request as draft May 17, 2022 20:54
@jeromelaban jeromelaban force-pushed the dev/jela/winui-update branch from 12f4249 to b079fa1 Compare May 18, 2022 15:11
@mattleibow mattleibow added this to the v2.88.1 milestone May 22, 2022
@jeromelaban jeromelaban force-pushed the dev/jela/winui-update branch from 665b855 to afbb8fe Compare May 22, 2022 19:52
@jeromelaban jeromelaban marked this pull request as ready for review May 22, 2022 19:59
mattleibow
mattleibow previously approved these changes May 26, 2022
Cannot build for wasm AOT on mac with current 2.x wasm bootstrapper.
Copy link
Contributor

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been a long one and it is a big one. But, it is a green one!

mattleibow added a commit that referenced this pull request May 27, 2022
Co-authored-by: Pavel Anpin <pavel@apes.ge>
Co-authored-by: Jerome Laban <jerome.laban@nventive.com>
@mattleibow mattleibow closed this May 27, 2022
@mattleibow mattleibow mentioned this pull request May 27, 2022
4 tasks
@mattleibow mattleibow reopened this May 27, 2022
@mattleibow mattleibow closed this May 27, 2022
@mattleibow mattleibow reopened this May 27, 2022
mattleibow added a commit that referenced this pull request May 27, 2022
@mattleibow mattleibow merged commit a6c2d0f into mono:main May 27, 2022
@mattleibow mattleibow linked an issue May 27, 2022 that may be closed by this pull request
@TopperDEL
Copy link

When will that Nuget be available? Is this bound to a release of something else?

@mattleibow
Copy link
Contributor

It should be coming out soon. I am just trying to get CI to build it as we type. Something just gave up and dies so now it runs out of disk space on CI... So it says. Hopefully this weekend or next week.

@TopperDEL
Copy link

That's nice! Thanks for the update! :)

@TopperDEL
Copy link

Any news on this one @mattleibow?

@TopperDEL
Copy link

The package is there! Thank you! :)

@mattleibow
Copy link
Contributor

Yeah, sorry about not updating this issue. I pushed the nuget and then started on some international flights.

@TopperDEL
Copy link

All fine! I just polled nuget.org until I found the package and have been the first one to download it. 🤣
Thanks for your work and your update on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[FEATURE] Views for Uno WinUI 3

4 participants